Shape of the page
A shell: the release week in a rail, a bar that stays put, and one migration filling the well. The first screen is a verdict, and the conversation that earned it follows.
What it leads with
A figure, 4 m 12 s, set against a budget of 30 s. The review reads as sentences, with the chart, the diff and the checks under the lines that cite them.
Spacing
GitHub's compact setting: 14 px text and 32 px controls. On a touch screen the controls keep their size and the tap area grows around them.
The one bold decision
Colour never carries state alone. Open, merged and closed each get an icon, a word and a silhouette, and the lock chart says what it means in length and in words.
- Try the review
- Apply mo-adeyemi's suggestion and the file, the replay, the chart, the checks and the apply box all answer. Resolve the conversation and ask for a new review, and mo-adeyemi approves the split version. Applying then opens, asks when it runs and what it costs, and queues the migration for the window, with a way to take it back.
- The three state marks
- Open is a filled pill, merged a filled bar, closed an outline with nothing in it. In grey print, open and merged are the same tone in every theme GitHub ships, so the shape, the icon and the word do the telling.
- The lock chart
- Each bar is a statement holding its lock, drawn to one clock, so the long one is long before it is read. The rule on the second row is 30 s after that statement starts, and the red begins where the budget ends.
- Labels
- Each label takes its text and its fill from one themed pair, so contrast is GitHub's measured figure and not a guess from a colour. The lowest of the three is 4.93:1 in light and 6.27:1 in dark.
- Dark
- Dark is its own theme with its own measured pairs, not the light page inverted. The diff tints, the label pairs and the chart bars are each read again on that ground.
- Keyboard
- Press ? for the list. J and K walk the conversation, R re-runs the checks, A applies the suggestion, and / filters the release week.
- Line numbers
- The rows of a diff are too close together for a line number to be a safe tap target. A number only identifies its line. A link to the page still lands on it and highlights it, and the links that reach a line sit in the sentences discussing it.
- The palette
- Nothing in the palette. Two readability standards disagree about those two pairs at these sizes. The values are GitHub's own, and rewriting them here would break the other themes Primer ships.